-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed backup so only old backup files are deleted #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashboy1998
commented
Jan 30, 2024
Dashboy1998
changed the title
DRAFT: Changed back so only files are deleted, only backup files, and added su.
Changed back so only files are deleted, only backup files, and added su.
Jan 30, 2024
Dashboy1998
changed the title
Changed back so only files are deleted, only backup files, and added su.
Changed backup so only old backup files are deleted
Jan 30, 2024
Dashboy1998
commented
Jan 30, 2024
thijsvanloef
requested changes
Jan 31, 2024
thijsvanloef
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ready to merge?
Yes. |
MusclePr
pushed a commit
to MusclePr/palworld-server-docker
that referenced
this pull request
Jun 19, 2024
Changed backup so only old backup files are deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
OLD_BACKUP_DAYS
in the backup folder is deleted including directories or non backup filesChoices
Test instructions
DELETE_OLD_BACKUPS=true
docker exec -it palworld-server bash
cd /palworld/backups
find /palworld/backups/ -exec touch -d "9001 days ago" {} \;
mkdir keep empty
mv palworld-save-2024-01-.... keep/
mv palworld-save-2024-01-.... important_palworld-save-2024-01-....
DELETE_OLD_BACKUPS=
and run a backup.Unable to deleted old backups, OLD_BACKUP_DAYS is empty.
DELETE_OLD_BACKUPS=30b
and run a backup.Unable to deleted old backups, OLD_BACKUP_DAYS is not an integer. OLD_BACKUP_DAYS=30b
Checklist before requesting a review