-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cron update #209
Cron update #209
Conversation
Co-authored-by: Carlos Martinez <[email protected]>
Co-authored-by: Carlos Martinez <[email protected]>
Co-authored-by: Carlos Martinez <[email protected]>
Co-authored-by: Carlos Martinez <[email protected]>
Co-authored-by: Carlos Martinez <[email protected]>
Co-authored-by: Carlos Martinez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
thank you for the review and fixing my bad code. Great Input, you're a legend 💯 |
You're code was pretty good already. I just pointed out a few typos and mentioned a few edge cases. |
@Luatan thanks for your work! |
@Luatan Some linting errors remain, if they are solved, will merge and add to next release :) |
@Luatan Tested it locally ran into no issues, thank you for your amazing work, merging :) |
Context
Choices
Test instructions
UPDATE_CRON_EXPRESSION
to* * * *
WARN_MINUTES
to1
A Real world test is still needed
Checklist before requesting a review