Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing of all config trough ENV #175

Merged
merged 8 commits into from
Jan 28, 2024
Merged

Allow changing of all config trough ENV #175

merged 8 commits into from
Jan 28, 2024

Conversation

thijsvanloef
Copy link
Owner

@thijsvanloef thijsvanloef commented Jan 28, 2024

Context

Prevent people from having to change files in order to change game options

Choices

Add environment variables for every option in the game

Test instructions

Set custom options and see if the PalWorldSettings.ini gets changed

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef
Copy link
Owner Author

Still need to document everything

@thijsvanloef thijsvanloef marked this pull request as ready for review January 28, 2024 11:24
@thijsvanloef thijsvanloef self-assigned this Jan 28, 2024
@thijsvanloef thijsvanloef added the enhancement New feature or request label Jan 28, 2024
@thijsvanloef thijsvanloef added the help wanted Extra attention is needed label Jan 28, 2024
Copy link
Contributor

@MSpreckels MSpreckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove configmap of palworldsetting.ini else it will get overridden

scripts/start.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@MSpreckels MSpreckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also remove the configmap reference from deployment

- mountPath: /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini

- name: palworld-settings

data:
PalWorldSettings.ini: >-
[/Script/OnlineSubsystemUtils.IpNetDriver]
NetServerMaxTickRate=60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this didn't work in the first place. We should make a PR and put this in Engine.ini.

@thijsvanloef
Copy link
Owner Author

@MSpreckels I think I got everything

@MSpreckels
Copy link
Contributor

MSpreckels commented Jan 28, 2024

Now we have some parameters that are appended to the startcommand and some that are replaced in the file. Wouldn't it make sense to even it out and set everything possible in file?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MSpreckels MSpreckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thijsvanloef
Copy link
Owner Author

@MSpreckels I've only changed some appended variables to the PalWorldSettings.ini. Mainly ENV's that include texts, as spacing could cause some trouble with the ini file

@thijsvanloef thijsvanloef merged commit 534b120 into main Jan 28, 2024
4 checks passed
@thijsvanloef thijsvanloef deleted the set-config branch January 28, 2024 16:57
@BIMGSE
Copy link

BIMGSE commented May 8, 2024

I change the ENV parameters through the stack editor, then I deploy

I want to add :

BUILD_OBJECT_DETERIORATION_DAMAGE_RATE=0.000000
DEATH_PENALTY=Item
PAL_EGG_DEFAULT_HATCHING_TIME=0.00100
image

at the end, but it doesn't work. My eggs still take 36hours to hatch. How do I solve this ? Obviously changing Palwordsettings.ini doesn't work at all.

MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Allow changing of all config trough ENV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment