-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing of all config trough ENV #175
Conversation
Still need to document everything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove configmap of palworldsetting.ini else it will get overridden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also remove the configmap reference from deployment
- mountPath: /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini |
- name: palworld-settings |
data: | ||
PalWorldSettings.ini: >- | ||
[/Script/OnlineSubsystemUtils.IpNetDriver] | ||
NetServerMaxTickRate=60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this didn't work in the first place. We should make a PR and put this in Engine.ini.
@MSpreckels I think I got everything |
Now we have some parameters that are appended to the startcommand and some that are replaced in the file. Wouldn't it make sense to even it out and set everything possible in file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MSpreckels I've only changed some appended variables to the PalWorldSettings.ini. Mainly ENV's that include texts, as spacing could cause some trouble with the ini file |
Allow changing of all config trough ENV
Context
Prevent people from having to change files in order to change game options
Choices
Add environment variables for every option in the game
Test instructions
Set custom options and see if the PalWorldSettings.ini gets changed
Checklist before requesting a review