Change html-lang-valid selector so the rule only applies when attrs h…

…ave a value. Fix dequelabs#3624
thibaudcolas · Sep 24, 2022 · 8b4829b · 8b4829b
1 parent cb9df98
commit 8b4829b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rules/html-lang-valid.json b/lib/rules/html-lang-valid.json
@@ -1,6 +1,6 @@
 {
   "id": "html-lang-valid",
-  "selector": "html[lang], html[xml\\:lang]",
+  "selector": "html[lang]:not([lang=\"\"]), html[xml\\:lang]:not([xml\\:lang=\"\"])",
   "tags": ["cat.language", "wcag2a", "wcag311", "ACT"],
   "actIds": ["bf051a"],
   "metadata": {

diff --git a/test/integration/virtual-rules/html-lang-valid.js b/test/integration/virtual-rules/html-lang-valid.js
@@ -6,6 +6,21 @@ describe('html-lang-valid virtual-rule', function() {
       attributes: {}
     });
 
+    assert.lengthOf(results.inapplicable, 1);
+    assert.lengthOf(results.passes, 0);
+    assert.lengthOf(results.violations, 0);
+    assert.lengthOf(results.incomplete, 0);
+  });
+
+	it('is inapplicable with empty lang or xml:lang', function() {
+    // Error caught by html-has-lang instead
+    var results = axe.runVirtualRule('html-lang-valid', {
+      nodeName: 'html',
+      attributes: {
+        'lang': '',
+      }
+    });
+
     assert.lengthOf(results.inapplicable, 1);
     assert.lengthOf(results.passes, 0);
     assert.lengthOf(results.violations, 0);