Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added query param handling of arrays so that single values are receiv… #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nthngalone
Copy link

@nthngalone nthngalone commented Oct 3, 2020

Update for issue #99

Greetings! I stumbled upon your repository last night while looking for interesting projects for #hacktoberfest. I will admit, I love this approach to building RESTful services. It mirrors almost exactly my experience with working with jax-rs in Java REST services. Its a very clear and concise approach to working with REST. I plan on using this in some upcoming personal projects.

Updated ./src/server/parameter-processor.ts for better handling of expected array types on query parameters.

  • Added a concat step when the expected type is an array. This will convert single objects into an array of one or preserve existing arrays as-is
  • Added tests for array query params types
  • Fixed a typo in the description of a test that I just happened to notice
  • Code coverage slightly improved by additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant