Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(): Allow headers option #9

Merged
merged 3 commits into from
Aug 9, 2017
Merged

add(): Allow headers option #9

merged 3 commits into from
Aug 9, 2017

Conversation

calamitoso
Copy link

@thgh Hello, I was looking into a way to extend the server to allow custom headers and could not find one, let me know if you'd consider passing an option like this or if you think there's a better approach

@calamitoso calamitoso force-pushed the master branch 2 times, most recently from 45324e6 to 87feb2d Compare August 7, 2017 02:49
@thgh
Copy link
Owner

thgh commented Aug 7, 2017

Looks good but it should match the API of webpack-dev-server, so developers don't have to relearn anything. Do you mind updating this PR?

@calamitoso
Copy link
Author

@thgh thanks for the feedback, I have made the changes

@thgh thgh merged commit eb41104 into thgh:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants