-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README doesn't mention lua-c++ requirement #217
Comments
a8bc29c muddies the issue a bit. |
@ryandesign I agree that README should mention that C++ Lua library variant is required and will soon improve it. @MarcusCalhoun-Lopez C++ Lua library can have unmangled symbols but it requires patched src/luaconf.h file (see https://sources.debian.org/patches/lua5.4/5.4.4-3/0003-extern_C.patch/). If symbols are mangled then Non C++ Lua library could also be used, but it would leak memory on Lua errors, because Lua uses different error handling method depending on used compiler. C version uses longjump and C++ version uses exceptions. If some C++ function expects to release allocated memory on exit from function or scope, then this release will not happen if longjump is used, because a simple jump to Lua error handling code will be performed. |
The README mentions that lua is required, but since gpick 0.3 it requires lua-c++ which is not in a standard lua install. The README should mention this unusual requirement, possibly with pointers on how to install lua-c++.
The text was updated successfully, but these errors were encountered: