Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Show git revision in version string when admin #637

Closed
cnelsonsic opened this issue Dec 24, 2021 · 3 comments
Closed

[FEATURE]: Show git revision in version string when admin #637

cnelsonsic opened this issue Dec 24, 2021 · 3 comments
Labels
waiting on user input Waiting for issues to respond on last question

Comments

@cnelsonsic
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When I'm deploying software it's nice to be able to see exactly what I've deployed, the overall version is good, but a git hash in addition would be better.

Describe the solution you'd like
I'd like to be able to show the git revision to admin users and maybe expose it via api.

Additional context
The ability to show admin-defined environment variables in the footer would also be very nice, maybe by a block of jinja an admin could type in a textbox.

I might end up implementing this one if it sounds okay to @theyosh and/or isn't already a thing.

@theyosh
Copy link
Owner

theyosh commented Dec 26, 2021

Hi, I see what you mean. And I think it is handy to have. And for docker, it is not that hard to make. During the build we can figure out the last commit and use that hash.

And when you use git to clone this repo, then I can make some code that reads out the last git hash during startup.

But, people that just download the zip file of a release, those people will not have any git information. So then a git hash should already be added to the code, which is a bit hard, as it is only available after creating a release. So I think, for those, that information is not available..

@theyosh
Copy link
Owner

theyosh commented Apr 11, 2022

This is now added in the new release. When you are logged in, you will see the commit hash in the source code at the header and in the footer of the GUI.

@theyosh theyosh added the waiting on user input Waiting for issues to respond on last question label Apr 11, 2022
@theyosh
Copy link
Owner

theyosh commented May 5, 2022

Ok, I am closing this now, as this is now also in the Docker build script and activated in the Github actions: https://github.com/theyosh/TerrariumPI/blob/main/.github/workflows/docker.yaml#L68=

Only when people download the zip file, they will not see Git revision info.

@theyosh theyosh closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on user input Waiting for issues to respond on last question
Projects
None yet
Development

No branches or pull requests

2 participants