Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temperature number the same, no matter the units #238

Closed
grantlarouere opened this issue Jan 13, 2019 · 5 comments
Closed

Temperature number the same, no matter the units #238

grantlarouere opened this issue Jan 13, 2019 · 5 comments

Comments

@grantlarouere
Copy link

grantlarouere commented Jan 13, 2019 •
edited
Loading

When I change the temperature units on my DHT22 sensor from C to F or K, the number stays identical. The value is not translating correctly. Also, thank you so much for sharing this great project and I'm really looking forward to setting everything up, once this issue is figured out.
@grantlarouere grantlarouere changed the title temperature always the same Temperature number the same, no matter the units Jan 13, 2019
@grantlarouere
Copy link
Author

I've done some minor troubleshooting and the temperature number displayed is always in C, even if I select F or K, the letter next to the number will state F or K, but the number value is always that of C.

theyosh added a commit that referenced this issue Jan 13, 2019
@theyosh
Fix sensor values other then Celcius. #238
2fb6dd9
@theyosh
Copy link
Owner

theyosh commented Jan 13, 2019

You found a bug. And it is fixed now. I did not return the right value. If you do a git pull and restart the software, it should work as expected.

Thanks for notifying

theyosh added a commit that referenced this issue Jan 13, 2019
@theyosh
Better fix temperture values. #238
8d5934a
@grantlarouere
Copy link
Author

It's displaying correctly now. Thank you for the fast fix!

theyosh added a commit that referenced this issue Jan 13, 2019
@theyosh
Fix CPU temp indicator. #238
bb21de7
@theyosh
Copy link
Owner

theyosh commented Jan 14, 2019

Closing due to fixed.

@theyosh theyosh closed this as completed Jan 14, 2019
@theyosh
Copy link
Owner

theyosh commented Jan 30, 2019

@grantlarouere Can I ask you to look at #210 ?

theyosh added a commit that referenced this issue Mar 22, 2021
@theyosh
Fix sensor values other then Celcius. #238
4fe92a1
theyosh added a commit that referenced this issue Mar 22, 2021
@theyosh
Better fix temperture values. #238
e300821
theyosh added a commit that referenced this issue Mar 22, 2021
@theyosh
Fix CPU temp indicator. #238
fabd46e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theyosh @grantlarouere