Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Card component #39

Closed
ghost opened this issue Jan 19, 2021 · 13 comments · Fixed by #50
Closed

Improve Card component #39

ghost opened this issue Jan 19, 2021 · 13 comments · Fixed by #50
Labels
bug Something isn't working Design DWOC Issues will be counted in devscript winter of Code Level-3

Comments

@ghost
Copy link

ghost commented Jan 19, 2021

  • UI needs to be upgraded and minimized (CSS and Design)
  • JSON data need to be passed using dummy data ( rendering component )
  • Component should be rendered on the next page ( as the first one will be the landing page )
@ghost ghost added this to the First Version of IDEALAB milestone Jan 19, 2021
@ghost ghost added bug Something isn't working Design DWOC Issues will be counted in devscript winter of Code Level-3 labels Jan 19, 2021
@sanjay270899
Copy link
Member

@JoshuaPoddoku I would like to work on this.

@ghost
Copy link
Author

ghost commented Jan 19, 2021

Yes whenever you u make initial changes add a Snapshot here @sanjay270899

@sanjay270899
Copy link
Member

@JoshuaPoddoku Can I get color hex-codes used in the card component?

@ghost
Copy link
Author

ghost commented Jan 21, 2021

You can use color picker chrome extension

@ghost
Copy link
Author

ghost commented Jan 21, 2021

@sanjay270899 , Find the style guide here: https://github.com/theupweb/idea-lab/blob/main/docs/style-guide.md

@sanjay270899
Copy link
Member

@JoshuaPoddoku Is the structure of JSON for card components fine?

image

@ghost
Copy link
Author

ghost commented Jan 21, 2021

@sanjay270899 Yes.

@sanjay270899
Copy link
Member

@JoshuaPoddoku
image

@sanjay270899
Copy link
Member

@JoshuaPoddoku Is it fine?

@ghost
Copy link
Author

ghost commented Jan 27, 2021

This is the design? or Implementation?

@sanjay270899 Looks great though

@sanjay270899
Copy link
Member

@JoshuaPoddoku
Implementation (code). I have implemented card design from scratch as Card.js component.

Should I send PR?

@ghost
Copy link
Author

ghost commented Jan 27, 2021 via email

@sanjay270899 sanjay270899 mentioned this issue Jan 27, 2021
@ghost ghost linked a pull request Jan 30, 2021 that will close this issue
@jatinjain001
Copy link

I would like to work on it please assign it to me if it is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Design DWOC Issues will be counted in devscript winter of Code Level-3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants