-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUF website Docsy themed version #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
Also, I'm not seeing any content for content/en/resources
Signed-off-by: sandra <[email protected]>
@Dindihub - FYI, I'm working with @nate-double-u to try to get deploy previews enabled for the |
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
It was in the .gitignore file as resources/. It's now visible |
Co-authored-by: Patrice Chalin <[email protected]>
Signed-off-by: sandra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dindihub - take a look at https://deploy-preview-68--theupdateframework.netlify.app and you'll see that it is different from your repo's rendition. I'll fix that; it seems to be because the version of Hugo being used, isn't correct due to the wrong build commands being used.
Note that you'll need to copy over and include the following in this PR
- All of the dot files and folders such as
.github
,.cspell.yml
, etc. - The LICENSE files
- The updated Makefile
- The updated README.md (keep the current badge)
Edit: track required additions via:
Hmm, the version of |
Updating |
Ah, it's because of the @JustinCappos et al. - would you be ok with the addition of theupdateframework.io/netlify.toml Line 29 in f7cc8f8
|
Is there a reasonable workaround? Why do we need this? It's a bad look for a security project to disable security controls, even if they don't matter in this case. |
Ok, I'll propose a workaround in a followup PR. Thanks for the feedback @JustinCappos. Edit: track workaround via: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good enough as a first PR over the docsy
branch. I'll follow up with the issues mentioned here but not yet addressed.
Signed-off-by: sandra <[email protected]> Co-authored-by: Patrice Chalin <[email protected]>
This is the Docsy theme version of the TUF website.
Please review @chalin @lukpueh