-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TAP 8 to accepted #187
Conversation
revocation has been moved ot TAP 20. Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm not sure if an optional/conditional client workflow is typically documented but, I asked for my own knowledge at least. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I must say though that I don't quite understand the sections about TAP 4 and TAP 3: Half of the TAP 4 section talks about mirrors, which are not related to TAP 4, and the other half is a bit vague ("repository manager must ensure that they have the same set of trusted keys after all rotations" ... who are they and why?). And the section about TAP 3 seems to describe the same rotation process as without TAP 3. Or am I missing something?
Either way, I don't think these two sections should block the TAP. The basic idea sounds reasonable to me.
Unfortunately, the POC seems outdated, but IIUC the official (and lived) TAP process does not required a full implementation before the final status.
Co-authored-by: John Kjell <[email protected]> Signed-off-by: Marina Moore <[email protected]>
Thanks all for moving this long-outstanding TAP fwd. I can't speak for @jku, but we have some reservations about the complexity this TAP adds, although we understand the value it could add to OSS package registries like PyPI, so we probably weren't the best people to review it. Thanks again! |
No description provided.