Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulcio draft #168

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fulcio draft #168

merged 2 commits into from
Mar 1, 2023

Conversation

mnm678
Copy link
Contributor

@mnm678 mnm678 commented Feb 7, 2023

Requires #141

Add a TAP number and make follow-up changes from #141

Clarifications include:
* linking to the root-signing repository
* replacing "bundle" with "sig" for backwards compatibility

Signed-off-by: Marina Moore <[email protected]>
@mnm678 mnm678 marked this pull request as ready for review February 7, 2023 18:17
Signed-off-by: Marina Moore <[email protected]>
tap18.md Show resolved Hide resolved
Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. I sent minor editing comments to Marina over slack, but there is nothing factually wrong with the TAP proposal and I approve it being merged as Draft.

@mnm678
Copy link
Contributor Author

mnm678 commented Mar 1, 2023

Thanks! I will merge this to get the TAP number assigned, and follow up with a pr for the minor edits

@mnm678 mnm678 merged commit ff6a66f into theupdateframework:master Mar 1, 2023
@mnm678 mnm678 deleted the fulcio-draft branch March 1, 2023 15:10
@mnm678 mnm678 mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants