Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why we check hashes before signatures #142

Conversation

trishankatdatadog
Copy link
Member

An attempt to fix #138

Does this look good @tedbow?

Signed-off-by: Trishank Karthik Kuppusamy [email protected]

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this, @trishankatdatadog. I wonder if we can make it more concise.

It is safe to check the hashes before the signatures, because the hashes comes from the timestamp role, which we have already verified in the previous step

feels a bit redundant to

hashes ... listed in the trusted timestamp metadata

Maybe it's enough to just expand what's already there, e.g.

hashes ... listed in the above/previously/already verified and thus trusted timestamp metadata

?

On the other hand, it seems worthwhile to elaborate on the

quick way to reject bad metadata

What about something along the lines of

preliminary integrity check before performing a more expensive signature verification

?

Besides, should this be part of the spec or is it rather a contender for secondary literature (#91)?

@trishankatdatadog
Copy link
Member Author

Sounds good, I will address your comments. In the meantime, I think we should add this to the spec, because that's where the question came up for php-tuf while implementing, but I'll let @tedbow decide.

@joshuagl
Copy link
Member

I agree that the spec is a good place for this, at least until we have the secondary literature. There are other parts of the spec where we explain why things are they way they are, such as the recently introduced fixed update start time.

@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/explain-why-check-hashes-first branch from 320ba2f to 8091c5a Compare September 7, 2021 16:06
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>

bump version
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/explain-why-check-hashes-first branch from 003b748 to 5107517 Compare September 7, 2021 16:09
@trishankatdatadog
Copy link
Member Author

@joshuagl @mnm678 PTAL 👀

joshuagl
joshuagl previously approved these changes Sep 7, 2021
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Trishank

tuf-spec.md Outdated Show resolved Hide resolved
tuf-spec.md Outdated Show resolved Hide resolved
Co-authored-by: Joshua Lock <[email protected]>
Co-authored-by: Joshua Lock <[email protected]>
@mnm678 mnm678 merged commit 2585a4e into theupdateframework:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain why checking some hashes before signatures is ok?
4 participants