Minor, mostly packaging, clean-ups #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version is no longer duplicated in setup.cfg (since 5155ba7), so remove redundant TODO suggesting folks update in two places. Co-authored-by: Ofek Lev <[email protected]> Signed-off-by: Joshua Lock <[email protected]>
Enable tox isolated environments to perform build operations in a virtual environment. See https://tox.wiki/en/latest/config.html#conf-isolated_build Co-Authored-By: Ofek Lev <[email protected]> Signed-off-by: Joshua Lock <[email protected]>
Setting upper bound version constraints in libraries is a source of problems for users of those libraries, see: https://iscinumpy.dev/post/bound-version-constraints/ The intent of the python-tuf version constraint is to ensure we're using a version of Python which supports all the features we rely on, this is a better fit for a lower limit. Suggested-by: Ofek Lev <[email protected]> Signed-off-by: Joshua Lock <[email protected]>
Fix the directory ignore patterns to ignore the entire directories, including child directories. https://git-scm.com/docs/gitignore#_pattern_format Co-authored-by: Ofek Lev <[email protected]> Signed-off-by: Joshua Lock <[email protected]>
Pull Request Test Coverage Report for Build 1958010688
💛 - Coveralls |
ofek
approved these changes
Mar 9, 2022
jku
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Great fixes, thanks. I disagree with the reasoning for python_requires change: The case made in the linked blog post applies to libraries, and in that case I agree completely. In the case of python we absolutely know that if there ever is a Python 4, it's going to be a breaking change (a new ecosystem in a sense).
I'll approve this anyway, preparation for Python 4 might not be the thing to argue about 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls a bunch of fixes suggested by @ofek from #1896
Description of the changes being introduced by the pull request:
tuf/__init__.pypython_requiresin setup.cfgPlease verify and check that the pull request fulfills the following
requirements: