Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_delegate() document ValueError and TypeError #1838

Conversation

MVrachev
Copy link
Collaborator

@MVrachev MVrachev commented Feb 8, 2022

Fixes #1817

Description of the changes being introduced by the pull request:

Add missing documentation for ValueError and TypeError inside
Metadata.verify_delegate().

Signed-off-by: Martin Vrachev [email protected]

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@coveralls
Copy link

coveralls commented Feb 8, 2022

Pull Request Test Coverage Report for Build 1811894055

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.343%

Totals Coverage Status
Change from base Build 1811836431: 0.0%
Covered Lines: 1118
Relevant Lines: 1134

💛 - Coveralls

Add missing documentation for ValueError and TypeError inside
Metadata.verify_delegate().

Signed-off-by: Martin Vrachev <[email protected]>
@MVrachev MVrachev force-pushed the verify-delegate-document-exceptions branch from a4d89c5 to 5f51579 Compare February 8, 2022 11:11
@MVrachev MVrachev requested a review from lukpueh February 8, 2022 11:11
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukpueh lukpueh merged commit 1e36ec6 into theupdateframework:develop Feb 8, 2022
@MVrachev MVrachev deleted the verify-delegate-document-exceptions branch February 8, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata API: verify_delegate() should document errors
3 participants