-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Refactor key rotation in simulator #1766
tests: Refactor key rotation in simulator #1766
Conversation
Pull Request Test Coverage Report for Build 1686443126
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactoring.
Add a method to rotate roles keys into RepositorySimulator (only top-level roles are supported for now). Rotation is used in four places already and this refactoring makes the tests easier to understand. Signed-off-by: Jussi Kukkonen <[email protected]>
b11b3b3
to
a38bf7c
Compare
improved variable names as Kairo suggested, no other changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Kairo.
Great refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice DRY, @jku!
Add a method to rotate roles keys into RepositorySimulator (only
top-level roles are supported for now). Rotation is used in four
places already and this refactoring makes the tests easier to
understand.
Signed-off-by: Jussi Kukkonen [email protected]