Update ngclient to skip visited nodes on delegation tree traversal #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing the delegation tree traversal requires changes in the implementation that are not related to this change and as a major update of the tests is already in the process of writing, I'm pushing this change relying only on current tests and logic assumptions. |
Pull Request Test Coverage Report for Build 1477552793
💛 - Coveralls |
This change edits the ngclient `Updater` to traverse the delegation tree on nodes, instead of edges in order to skip already visited nodes. For more detailed clarification, please review theupdateframework/specification#177 Fixes theupdateframework#1528 Signed-off-by: Ivana Atanasova <[email protected]>
ivanayov
force-pushed
the
ivanayov/ngclient_skip_visited_roles
branch
from
f5ee005 to
aff96c3
Compare
sechkova
approved these changes
Nov 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change edits the ngclient
Updaterto traverse the delegationtree on nodes, instead of edges in order to skip already visited
nodes.
For more detailed clarification, please review
theupdateframework/specification#177
Fixes #1528
Signed-off-by: Ivana Atanasova [email protected]