Metadata API: Fix Metadata.sign() return value annotation #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason mypy does not complain about this yet is that we currently disable mypy for securesystemslib: This makes Signer.sign() return value |
jku
changed the title
We've been returning Signature objects since 49aa0fc. Also add a test case that does something with the returned signature. Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
fix-sign-return-value
branch
from
caf278c to
505b82a
Compare
|
rebase on develop, no changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been returning Signature objects since 49aa0fc.
Also add a test case that does something with the returned signature.
Signed-off-by: Jussi Kukkonen [email protected]