api: Lint metadata.py

[rzr]

While working using pylint 2.5.3 (from debian package 2.5.3-2)
I noticed those warnings that were not triggered
by current tox configuration.

This will not harm to support several pylint version.

Change-Id: I7f4d5d56a157cab27f19cfe74cd74baa893c1d93
Signed-off-by: Philippe Coval [email protected]

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following
requirements:

• The code follows the Code Style Guidelines
• Tests have been added for the bug fix or new feature
• Docs have been added for the bug fix or new feature

[joshuagl]

Thank you for the PR Philippe. These changes look appropriate. I wonder why the current tox configuration did not pick up these issues, it seems we are perhaps not properly listing this file?

[rzr]

Ok I investigated a bit it looks like latest pylint 2.7.2 removed this "bad-continuation" feature

pylint-dev/pylint#3571

while it was still present in earlier version (2.5.3 at least)

Since 2.6 upstream suggests to use black formater:

https://github.com/PyCQA/pylint/blob/4faccd0563c628954f04322ffb696905a3dab62d/doc/whatsnew/2.6.rst

Any objection to use black for formatting ?:
#1178

Nevertheless is this change still desirable?
I will update commit message and refresh this PR.

[lukpueh]

Nevertheless is this change still desirable?

Yes! But maybe we can defer this PR until we have a proper linter/auto-formatter config (#1178)? And then have a flag day, where we make all changes, grouping them thematically by commit? What do you think?

[rzr]

Hi @lukpueh , sure this can be delayed since it's not critical at all.

May i suggest this change to be merged for next version if we fail to setup linter before releasing

I'll see how can I help with black:
#1178

[lukpueh]

Superseded by #1314.

[lukpueh]

Thanks for the getting the ball rolling, @rzr!