-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use changed format metadata to key #1016
Refactor to use changed format metadata to key #1016
Conversation
0f0baa7
to
152068b
Compare
I made changes to this pr, but in order to tests those changes a new version of securesyslib should be published adding the changes in the format_metadata_to_key. |
152068b
to
e03b098
Compare
I rebased on the recent changes in the develop branch and the tests should no longer fail, but I don't know why |
Hi @MVrachev. With the release of securesystemslib 0.16.0 we are ready to include this change. Could you rebase this on the latest develop branch and when doing so edit setup.py to bump the minimum version of securesystemslib in We should also stop passing |
In commit b7a15fdee7dee899c098b01fe64d604635b2b132 or pr secure-systems-lab/securesystemslib#227 in securesystemslib I change the function arguments of the format_metadata_to_key function in securesystemslib/keys.py to add the opportunity to use custom keyid hash algorithms without chainging the securesystemslib.settings.HASH_ALGORITHMS variable. With this commit, I make use of the above changes in tuf. Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
e03b098
to
7a828ea
Compare
Rebased upon the latest changes in tuf and bumped securesyslib to 0.16.0 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
PR theupdateframework#1014 removed uses of keyid_hash_algorithms in favour of using the calculated keyid values from the metadata. A few instances of this removal were unintentionally reintroduced in PR theupdateframework#1016, when changing to explicitly passing a list of hash algorithms rather than changing securesystemslib settings values. This change removes uneccessary uses of keyid_hash_algorithms. Signed-off-by: Joshua Lock <[email protected]>
PR theupdateframework#1014 removed uses of keyid_hash_algorithms in favour of using the calculated keyid values from the metadata. A few instances of this removal were unintentionally reintroduced in PR theupdateframework#1016, when changing to explicitly passing a list of hash algorithms rather than changing securesystemslib settings values. This change removes uneccessary uses of keyid_hash_algorithms. Signed-off-by: Joshua Lock <[email protected]>
Fixes issue #:
This pr enables tuf to use changes made in secure-systems-lab/securesystemslib#227
Don't merge before the above pr is merged!
Description of the changes being introduced by the pull request:
Because of issue secure-systems-lab/securesystemslib#227
I had to checkout to the last commit which doesn't had that issue and
make the current changes based on it.
Please verify and check that the pull request fulfills the following
requirements: