-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata API: validate that "paths" or "path_hash_prefixes" is set #1497
Comments
I don't think there's a clear consensus that that is the expected behaviour theupdateframework/specification#156 I thought |
Let's implement something which replicates the behaviour of the current client until the specification better defines what is expected. |
The specification does not state clearly what is the behaviour when none of delegation's "paths" and "path_hash_prefixes" is set. See theupdateframework#1497. Until this issue is clarified, copy current Updater which raises an error in such case. Signed-off-by: Teodora Sechkova <[email protected]>
The specification does not state clearly what is the behaviour when none of delegation's "paths" and "path_hash_prefixes" is set. See theupdateframework#1497. Until this issue is clarified, copy current Updater which raises an error in such case. Signed-off-by: Teodora Sechkova <[email protected]>
Done with 2159b88. |
The specification does not state clearly what is the behaviour when none of delegation's "paths" and "path_hash_prefixes" is set. See theupdateframework#1497. Until this issue is clarified, copy current Updater which raises an error in such case. Signed-off-by: Teodora Sechkova <[email protected]>
The specification does not state clearly what is the behaviour when none of delegation's "paths" and "path_hash_prefixes" is set. See theupdateframework#1497. Until this issue is clarified, copy current Updater which raises an error in such case. Signed-off-by: Teodora Sechkova <[email protected]>
The specification does not state clearly what is the behaviour when none of delegation's "paths" and "path_hash_prefixes" is set. See theupdateframework#1497. Until this issue is clarified, copy current Updater which raises an error in such case. Signed-off-by: Teodora Sechkova <[email protected]>
The specification does not state clearly what is the behaviour when none of delegation's "paths" and "path_hash_prefixes" is set. See theupdateframework#1497. Until this issue is clarified, copy current Updater which raises an error in such case. Signed-off-by: Teodora Sechkova <[email protected]>
76d4633 which replicates current client behaviour is merged so until the issue in the specification gets resolved, the client raises an error if none of paths and path_hash_prefixes is set. Closing this issue and will reopen if an update of the code is needed to conform to the spec. |
Description of issue or feature request:
As @sechkova have pointed out in this comment #1463 (comment) in
DelegatedRole
we are checking ifpaths
andpath_hash_prefixes
BOTH are set, but we aren't checkingif at least one of them is set:
https://github.com/theupdateframework/tuf/blob/24fa1128116429dc18e185047fbffb009ca509b0/tuf/api/metadata.py#L914
For more context read theupdateframework/specification#156.
Current behavior:
We don't check if BOTH
paths
andpath_hash_prefixes
are None.Expected behavior:
Check if BOTH
paths
andpath_hash_prefixes
are None.The text was updated successfully, but these errors were encountered: