Tests fail with recent change to formats.PATH_SCHEMA in securesystemslib master #1059
Milestone
Comments
MVrachev
added a commit
to MVrachev/securesystemslib
that referenced
this issue
Jun 29, 2020
In one of the latest commits AnyNonemptyString was introduced and with it, PATH_SCHEMA was changed to AnyNonemptyString from AnyString. This led to unit tests failures in TUF. See: theupdateframework/python-tuf#1059 One could argue what is the right approach: to consider that PATH_SCHEMA is every non-empty string or every string. I think this is not of much importance, but for TUF and possibly for other securesystemslib adopters, this leads to tests failures. The reason is that there are multiple functions with arguments which should conformant against the PATH_SCHEMA but have default values of ''. See : - "prefix" argument in load_repository function - "location_in_repository" argument in create_new_project function both of which are in tuf/developer_tool.py Signed-off-by: Martin Vrachev <[email protected]>
This was referenced Jun 29, 2020
Merged
|
Resolved with #1064 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of issue or feature request:
Tests fail with securesystemslib master since the change in secure-systems-lab/securesystemslib#244 to adapt
securesystemslib.formats.PATH_SCHEMAto usesecuresystemslib.schema.AnyNonEmptyStringSee a recent Travis log: https://travis-ci.org/github/theupdateframework/tuf/jobs/702415488
Current behavior:
Tests fail with securesystemslib master
Expected behavior:
Tests pass with securesystemslib master
The text was updated successfully, but these errors were encountered: