Skip to content

Commit

Permalink
Add lines and file count information
Browse files Browse the repository at this point in the history
Signed-off-by: Martin Vrachev <[email protected]>
  • Loading branch information
MVrachev committed Mar 30, 2021
1 parent b9e838a commit b486d24
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion docs/adr/0007-validation-guideliness.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,25 @@ Here is how all of our options compare against our requirements:
| 1 | Validate function args everywhere | Limited || Limited |||
| 2 | Custom deeper validation ||||||
| 3 | Performance overhead | Minimal | [Fastest](https://pydantic-docs.helpmanual.io/benchmarks/) | [Slower](https://pydantic-docs.helpmanual.io/benchmarks/) | No information | No information |
| 4 | Number of new depedencies | 0 | 2 | 1 | 1 | 1 |
| 4 | New [depedencies ; files ; lines of code;] | [0; no info; no info] | [2; 26; 8982] | [1; 13; 2652] | [1; 899; 3] | [1; 899; 3] |
| 5 | Support for all python versions ||||||
| 6 | Code reuse for validation ||||||
| 7 | Way to invoke all validators ||||||

For requirement number 4, the calculations were made with [sloccount](https://linux.die.net/man/1/sloccount)
on March 30-th 2021.
Those results were concluded by performing the following steps for each of the
options using third-party libraries:
1. Creating a fresh virtual environment with python3.8.
2. Installing all dependencies in `requirements-dev.txt` from `tuf`.
3. Install `<package_name>` with `pip install <package_name>`.
4. Use `sloccount` to count added lines and files by the package and its
dependencies.

Only source files were used when calculating the lines of code and number of
files (meaning all test files, doc folders, and other meta or configuration
files were excluded).

Bellow, in the following sections, there are additional pros, cons, and
considerations for each of the options.

Expand Down

0 comments on commit b486d24

Please sign in to comment.