-
Notifications
You must be signed in to change notification settings - Fork 272
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
update tests so that keyids do not have to be verified
Signed-off-by: marinamoore <[email protected]>
- Loading branch information
Showing
1 changed file
with
7 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c78d67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since these changes got integrated but I do have a question:
Line 393 is getting removed in favour of 397 without changing the internal key database.
Without getting the most recent TUF dependency, and locally running unit tests, that unit test fails as it raises the UnknownKeyError.
If I pull the latest of everything, then everything seems to work. But I cannot see from this commit how the test changed.
Thanks!
3c78d67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit was part of a pr to remove keyid_hash_algorithms. As part of that pr, TUF no longer re-computes keyids, but instead uses keyids provided by TUF metadata. Because of this change, a keyid calculated differently will be accepted and not cause an UnknownKeyError.
This test could probably use a better explanatory comment, feel free to open an issue.