-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding compatibility with V8 release greater than v7.6 (node and electron engines) #376
Conversation
I have tested this PR to build on npm v12 and it works as expected!! |
Nice! Does it also work with previous Node versions? |
@theturtle32 any chance to check this? It's becoming a real need... |
@ibc @belcherj I have run a prebuild compiling test with :
and it seems to build all the binary packages at least on Linux based systems. You might encounter some clashes on the most recent versions of OSX with the outdated releases of node/electron. It works fine on node v13 as well. Kind Regards |
I just tested with Node 10, and it builds fine + all the tests pass. Please accept the PR ASAP and release a new version. Thanks! |
@orgads thanks for your feedback ! |
Thanks for this PR and for confirming that it works in previous and new Node versions. I'll merge this PR. However publishing a new NPM package depends on @theturtle32. |
Thank you very much for merging my PR @ibc. I'm really glad for giving this contribution to the project ! |
I'll see if I can get to publishing this later today. Tomorrow at the latest. |
Thanks @theturtle32 |
1 similar comment
Thanks @theturtle32 |
Released v1.0.31 on npm. |
Thank you! |
As described in the object, this set of patches enable the build compatibility against most recent releases of node.js/electron and the updated NAN APIs