Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding compatibility with V8 release greater than v7.6 (node and electron engines) #376

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

artynet
Copy link
Contributor

@artynet artynet commented Oct 30, 2019

As described in the object, this set of patches enable the build compatibility against most recent releases of node.js/electron and the updated NAN APIs

@belcherj
Copy link

I have tested this PR to build on npm v12 and it works as expected!!

@ibc
Copy link
Collaborator

ibc commented Nov 23, 2019

Nice! Does it also work with previous Node versions?

@ibc
Copy link
Collaborator

ibc commented Nov 23, 2019

@theturtle32 any chance to check this? It's becoming a real need...

@artynet
Copy link
Contributor Author

artynet commented Nov 25, 2019

@ibc @belcherj I have run a prebuild compiling test with :

$ npm install -g prebuild
$ prebuild --all

and it seems to build all the binary packages at least on Linux based systems. You might encounter some clashes on the most recent versions of OSX with the outdated releases of node/electron. It works fine on node v13 as well.

Kind Regards

@orgads
Copy link

orgads commented Dec 1, 2019

I just tested with Node 10, and it builds fine + all the tests pass.

Please accept the PR ASAP and release a new version.

Thanks!

@artynet
Copy link
Contributor Author

artynet commented Dec 2, 2019

@orgads thanks for your feedback !

@ibc
Copy link
Collaborator

ibc commented Dec 3, 2019

Thanks for this PR and for confirming that it works in previous and new Node versions.

I'll merge this PR. However publishing a new NPM package depends on @theturtle32.

@ibc ibc merged commit 6c3ac5a into theturtle32:master Dec 3, 2019
@artynet
Copy link
Contributor Author

artynet commented Dec 4, 2019

Thank you very much for merging my PR @ibc. I'm really glad for giving this contribution to the project !

@theturtle32
Copy link
Owner

I'll see if I can get to publishing this later today. Tomorrow at the latest.

@ibc
Copy link
Collaborator

ibc commented Dec 4, 2019

Thanks @theturtle32

1 similar comment
@artynet
Copy link
Contributor Author

artynet commented Dec 5, 2019

Thanks @theturtle32

@theturtle32
Copy link
Owner

Released v1.0.31 on npm.

@orgads
Copy link

orgads commented Dec 8, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants