Update to your PR - merge latest and cleanup a bit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated models and fixed tests * Discarded model * Failing tests on CI/CD * Debugging tests on CI/CD * Applied PR suggested changes * error when running tests on CI/CD pipeline * Implemented approach from PR dotnet#343 for cancelling streamReader * Tests case is behaving differently while it runs on CI/CD pipeline * Merged changes from author fork * Error on CI/CD pipeline due to new Message.Status. Discarted Message.Status condition to validate event monitoring * Serialization for IList<byte> to base64 * PR suggestions by @galvesriverio * Updated test for DockerService_IsRunning * Renamed process name in tests * Updated version for Nerdbank.GitVersioning * Updated ProcesName in test Co-authored-by: timt <[email protected]>
# Conflicts: # src/Docker.DotNet/Endpoints/IImageOperations.cs
…ld BuildImageFromDockerfileAsync and obsolete it to not break anyone if this gets merged. Fix comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.