Update channel inversion example #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cpjordan
commented
Jun 7, 2024
cpjordan
commented
- Correct file paths in example for plotting
- Correct VTKFile paths for import
- Load times for the optimisation fields (one timestep less than existing files)
- Import from collections.abc (deprecation update)
- Update makefile so it works again and cycles through all the stations for plotting
- Correct file paths in example for plotting - Correct VTKFile paths for import - Load times for the optimisation fields (one timestep less than existing files) - Import from collections.abc (deprecation update)
stephankramer
requested changes
Jun 7, 2024
There was a problem hiding this comment.
VTKFile should now be available again from the top level firedrake module, and so again directly from either from firedrake import * or from thetis import * (see firedrakeproject/firedrake#3535). I prefer doing that - i.e. from thetis import * in example scripts and import firedrake as fd ... f = fd.VTKFile() in modules instead of from firedrake.output.vtk_output import VTKFile - as internal module hierarchies are likely to change...
Other than that, all looks good!
|
Ah - was working on an older version of Firedrake as it's a pain to update on my system because of the Ubuntu version. Updated now & tests running, thanks Stephan! |
stephankramer
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.