remove geometric boundary mask #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm guessing there isn't a difference because you use equispaced DG nodes? |
|
Yes, we need equispaced for e.g. the slope limiters to work |
As 'geometric' boundary mask has been removed, we cannot use FunctionSpace.cell_boundary_masks anymore to identify top/bottom facet nodes. The indices are computed manually instead.
jwallwork23
approved these changes
May 21, 2021
Comment on lines
+906
to
+910
| base_element_3d = get_extruded_base_element(self.fs_3d.ufl_element()) | ||
| assert isinstance(base_element_3d, ufl.TensorProductElement) | ||
| family_3dh = base_element_3d.sub_elements()[0].family() | ||
| if family_2d != family_3dh: | ||
| raise Exception('2D and 3D spaces do not match: {0:s} {1:s}'.format(family_2d, family_3dh)) |
There was a problem hiding this comment.
Could maybe write another utility function called something like check_element_consistency_2d-3d, since this is repeated a couple of times later?
There was a problem hiding this comment.
Yeah, sure. Will do in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firedrake boundary method
'geometric'has been removed in firedrakeproject/firedrake#2007For most (all?) Thetis use cases there's actually no difference between geometric and topological boundary masks (e.g. P1DG).The top/bottom facet mask indices have now been implemented manually.