refactor!: change Stream to work directly with a Socket #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit is only partially complete and should not be used
thetayloredman
changed the title
thetayloredman
changed the title
This deprecates StreamEvents.Close in favor of StreamEvents.End. Co-authored-by: ei-pi <[email protected]>
this makes Shell's tests unit tests instead of integration tests
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 87.96% 93.93% +5.96%
==========================================
Files 9 9
Lines 266 264 -2
Branches 38 44 +6
==========================================
+ Hits 234 248 +14
+ Misses 32 16 -16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Stream class to work directly with duplex streams instead of IO providers.