audio: kpb: fix potential NULL pointer dereference in device list reset #9691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmleman
requested review from
lgirdwood,
abonislawski,
kv2019i,
marcinszkudlinski,
softwarecki and
serhiy-katsyuba-intel
tmleman
force-pushed
the
topic/upstream/pr/kpb/fix/null_dereference
branch
from
65d0980
to
5171c84
Compare
serhiy-katsyuba-intel
approved these changes
Nov 28, 2024
kv2019i
approved these changes
Nov 28, 2024
This patch addresses a potential NULL pointer dereference issue in the `devicelist_reset` function within the Key Phrase Buffer (KPB) component. The issue was exposed by a recent change in Zephyr's MMU mapping for Intel ADSP ACE30, which now catches NULL pointer accesses. The `devicelist_reset` function previously iterated over the entire `DEVICE_LIST_SIZE` when clearing items and zeroing pointers, which could lead to dereferencing NULL pointers. The fix involves iterating only up to `devlist->count` to ensure that only valid pointers are accessed. This change prevents potential NULL pointer dereference and ensures the stability of the KPB component. Link: thesofproject#9687 Signed-off-by: Tomasz Leman <[email protected]>
lgirdwood
approved these changes
Nov 28, 2024
|
@tmleman can you check internal CI failure. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses a potential NULL pointer dereference issue in the
devicelist_resetfunction within the Key Phrase Buffer (KPB) component. The issue was exposed by a recent change in Zephyr's MMU mapping for Intel ADSP ACE30, which now catches NULL pointer accesses.The
devicelist_resetfunction previously iterated over the entireDEVICE_LIST_SIZEwhen clearing items and zeroing pointers, which could lead to dereferencing NULL pointers. The fix involves iterating only up todevlist->countto ensure that only valid pointers are accessed.This change prevents potential NULL pointer dereference and ensures the stability of the KPB component.