[stable-v2.2] platform: tigerlake: increase ALH group count #9604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PCM bidirectional FIFO count is 6 for Tigerlake hardware. Link: thesofproject#9571 Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
lgirdwood
approved these changes
Oct 21, 2024
|
Do we need to update the alh_handshake_map in src/platform/tigerlake/include/platform/drivers/alh.h? /* copier id = (group id << 4) + codec id + IPC4_ALH_DAI_INDEX_OFFSET
* dai_index = (group id << 8) + codec id;
*/
#define IPC4_ALH_DAI_INDEX(x) ((((x) & 0xF0) << DAI_NUM_ALH_BI_DIR_LINKS_GROUP) + \
(((x) & 0xF) - IPC4_ALH_DAI_INDEX_OFFSET))doesn't look correct to me. Should it be #define IPC4_ALH_DAI_INDEX(x) ((((x) & 0xF0) << 4) + \
(((x) & 0xF) - IPC4_ALH_DAI_INDEX_OFFSET))? Can we test it with a SDW codec that is on any SDW link other than link 0? Like SDW link 1, 2, or 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PCM bidirectional FIFO count is 6 for Tigerlake hardware.
Link: #9571