[SKIP SOF-TEST] fuzz.sh: add -jobs parameter. Switch to built-in -max_total_time. #8851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brand new failure in https://github.com/thesofproject/sof/actions/runs/7868973600/job/21467150473?pr=8851? Demoting to draft for now. |
@andyross is that another panic being masked? |
There was no need to use the external "timeout" command + some complicated exit code logic, libFuzzer has that feature built-in. Switch to it and delete a few good line. Add an option to use the built-in, concurrent -jobs feature which saves a massive amount of time. It has some quirks so do not enable it by default. Decrease verbosity by default. Add in the help message the magic replay command that saves a ton of time. Signed-off-by: Marc Herbert <[email protected]>
Use new option to fuzz more in the same time. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
requested review from
jxstelter,
LaurentiuM1234,
singalsu and
iuliana-prodan
"Unit test" crash-* files allow instant reproduction. fuzz-*.log files are created when using -j Signed-off-by: Marc Herbert <[email protected]>
lgirdwood
approved these changes
Feb 28, 2024
|
@marc-hb are all the dependencies in the PR message now met ? |
|
I did submit more than one PR to make debugging fuzzing issues significantly easier and faster but they are all independent of each other and can be merged in any order. This can be merged. When there are dependencies between commits I either put them in the same PR or if too big then I hold back depending PRs as drafts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no need to use the external "timeout" command + some complicated exit code logic, libFuzzer has that feature built-in. Switch to it and delete a few good line.
Add an option to use the built-in, concurrent -jobs feature which saves a massive amount of time. It has some quirks so do not enable it by default.
Decrease verbosity by default.
Add in the help message the magic replay command that saves a ton of time.
cc: