Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new --no-deployable-build option #8754

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jan 17, 2024

Everyone should use deployable builds by default. Don't switch the
default behavior yet but add a --no-deployable-build option in case
anyone is stuck.

Signed-off-by: Marc Herbert [email protected]

Everyone should use deployable builds by default.  Don't switch the
default behavior yet but add a --no-deployable-build option in case
anyone is stuck.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jan 17, 2024

Failures to compile with the Zephyr main branch are known and unrelated:
https://github.com/thesofproject/sof/actions/runs/7562861040/job/20594168710?pr=8754

implicit declaration of function 'z_smp_thread_init';

They're caused by backwards-incompatible change:

@marc-hb

This comment was marked as outdated.

@marc-hb marc-hb changed the title Add new --no-deployable-build option, make --deployable-build the default Add new --no-deployable-build option Jan 18, 2024
Copy link
Contributor

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marc-hb, I did not made it to the default to gave time for CIs to adapt.

@kv2019i kv2019i merged commit d324af5 into thesofproject:main Jan 23, 2024
39 of 44 checks passed
@marc-hb marc-hb deleted the deployable-by-default branch January 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants