Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nocodec amplifier+hdmi-in via I2S #7770

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Nocodec amplifier+hdmi-in via I2S #7770

merged 3 commits into from
Jun 21, 2023

Conversation

CBala21
Copy link
Contributor

@CBala21 CBala21 commented Jun 8, 2023

No description provided.

@CBala21 CBala21 changed the title Nocodec+hdmi Nocodec amplifier+hdmi-in via I2S Jun 8, 2023
@CBala21
Copy link
Contributor Author

CBala21 commented Jun 8, 2023 •
edited
Loading

Hi,

I hope the below checkpatch warning is known thing and nothing to do from our side. Please check and provide the comment.

WARNING: 'HDA' may be misspelled - perhaps 'HAD'?
#247: FILE: tools/topology/topology1/sof-tgl-rt1308-hdmi-ssp.m4:215:
+DAI_CONFIG(HDA, 7, 7, iDisp3,
^^^

WARNING: 'HDA' may be misspelled - perhaps 'HAD'?
#248: FILE: tools/topology/topology1/sof-tgl-rt1308-hdmi-ssp.m4:216:

  • HDA_CONFIG(HDA_CONFIG_DATA(HDA, 7, 48000, 2)))

@marc-hb
Copy link
Collaborator

marc-hb commented Jun 8, 2023

https://www.kernel.org/doc/html/latest/dev-tools/checkpatch.html

Checkpatch is not always right. Your judgement takes precedence over checkpatch messages. If your code looks better with the violations, then its probably best left alone.

This is very frequent with code style checks. They're right only the vast majority of the time but not all the time.

@CBala21
Copy link
Contributor Author

CBala21 commented Jun 12, 2023

Hi Team,

Please do help to review and merge.

kv2019i
kv2019i approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

plbossart
plbossart requested changes Jun 12, 2023
View reviewed changes
tools/topology/topology1/CMakeLists.txt Outdated Show resolved Hide resolved
tools/topology/topology1/sof-tgl-rt1308-hdmi-ssp.m4 Outdated Show resolved Hide resolved
tools/topology/topology1/sof-tgl-rt1308-hdmi-ssp.m4 Show resolved Hide resolved
tools/topology/topology1/sof-tgl-rt1308-hdmi-ssp.m4 Outdated Show resolved Hide resolved
@CBala21 CBala21 force-pushed the Nocodec+HDMI branch 2 times, most recently from 67ea204 to 7a4e89f Compare June 13, 2023 08:28
@CBala21 CBala21 requested a review from plbossart June 13, 2023 14:06
@CBala21
Copy link
Contributor Author

CBala21 commented Jun 19, 2023

Hi plbossart,

Please check the latest patch which has been fixed the review comments and help to do get merge.

plbossart
plbossart requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mclk_in support is questionable at best. see comments below

tools/topology/topology1/sof-tgl-rt1308-hdmi-ssp.m4 Show resolved Hide resolved
@CBala21 CBala21 requested a review from plbossart June 19, 2023 14:36
@CBala21
topology1: add support for rt1308 ssp amp + HDMI-in capture.
0510953 
Adding support for rt1308 ssp amplifier and HDMI-in capture via I2S.

Signed-off-by: Balamurugan C <[email protected]>
@CBala21
topology1: tgl: add support for Nocodec amp and HDMI-in capture.
8b16f20 
Adding support for the product which doesn't have no ssp amplifier
but need to support HDMI audio playback and HDMI-in capture via I2S.

Signed-off-by: Balamurugan C <[email protected]>
@CBala21
topology1: adl: add support for Nocodec amp and HDMI-in capture.
0db5674 
Adding support for the alderlake products which doesn't have no ssp
amplifier but need to support HDMI audio playback and HDMI-in capture
via I2S

Signed-off-by: Balamurugan C <[email protected]>
plbossart
plbossart approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @CBala21

@kv2019i kv2019i merged commit 81f5822 into thesofproject:main Jun 21, 2023
@CBala21 CBala21 deleted the Nocodec+HDMI branch August 4, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kv2019i kv2019i kv2019i approved these changes

@plbossart plbossart plbossart approved these changes

@marc-hb marc-hb Awaiting requested review from marc-hb

@aborisovich aborisovich Awaiting requested review from aborisovich

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CBala21 @marc-hb @plbossart @kv2019i