Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform: remove support for cAVS 1.5 platforms #7139

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

lyakh
Copy link
Collaborator

@lyakh lyakh commented Feb 21, 2023

Remove all support for cAVS 1.5 platformsm including Apollo Lake, Sky Lake, Kaby Lake, Broxton and Gemini Lake, they aren't supported any more.

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 21, 2023

SOFCI TEST

@lgirdwood
Copy link
Member

@marc-hb does CI need a script update for Jenkins FW build ?

@marc-hb
Copy link
Collaborator

marc-hb commented Feb 22, 2023

@marc-hb does CI need a script update for Jenkins FW build ?

Yes it looks like it but I don't know where sorry.
https://sof-ci.01.org/sofpr/PR7139/build4072/build/index.html

Different topic: to fix the dai_config_get + IPC4 failures in https://github.com/thesofproject/sof/actions/runs/4233757417/jobs/7355127923 simply do an empty git commit --amend -C HEAD and force push. Fixed in #6939

@@ -31,39 +31,6 @@
# - add a new one as array of bytes and append entry to KNOWN_KEYS below.
# you can use --full_bytes to dump the bytes in below format

APL_INTEL_PROD_KEY = bytes([0x1f, 0xf4, 0x58, 0x74, 0x64, 0xd4, 0xae, 0x90,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this key (and restore the older ones in different PR, sorry I missed this), this is going to break sof-bin tests for no good reason. This is just a pure constant with zero actual logic depending on it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb ok, removed. It wasn't changed in earlier PRs - BYT / BDW didn't use signed firmware AFAIK

Remove all support for cAVS 1.5 platformsm including Apollo Lake,
Sky Lake, Kaby Lake, Broxton and Gemini Lake, they aren't supported
any more.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One hopefully last request: can you remove the topologies in a separate commit? We're still discussing how topologies will be packaged and released. This should be a very quick change for you: simply move all the changes in tools/ to a separate commit.

@lyakh
Copy link
Collaborator Author

lyakh commented Mar 1, 2023

One hopefully last request: can you remove the topologies in a separate commit? We're still discussing how topologies will be packaged and released. This should be a very quick change for you: simply move all the changes in tools/ to a separate commit.

@marc-hb why? What difference does it make for this PR?

@marc-hb marc-hb dismissed their stale review March 1, 2023 16:21

stale

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 1, 2023

Never mind, I forgot other topologies were already removed like this.

@lgirdwood lgirdwood merged commit 0f0acaa into thesofproject:main Mar 2, 2023
@lyakh lyakh deleted the rm-cavs15 branch March 2, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants