-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform: remove support for cAVS 1.5 platforms #7139
Conversation
SOFCI TEST |
@marc-hb does CI need a script update for Jenkins FW build ? |
Yes it looks like it but I don't know where sorry. Different topic: to fix the |
tools/sof_ri_info/sof_ri_info.py
Outdated
@@ -31,39 +31,6 @@ | |||
# - add a new one as array of bytes and append entry to KNOWN_KEYS below. | |||
# you can use --full_bytes to dump the bytes in below format | |||
|
|||
APL_INTEL_PROD_KEY = bytes([0x1f, 0xf4, 0x58, 0x74, 0x64, 0xd4, 0xae, 0x90, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this key (and restore the older ones in different PR, sorry I missed this), this is going to break sof-bin tests for no good reason. This is just a pure constant with zero actual logic depending on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marc-hb ok, removed. It wasn't changed in earlier PRs - BYT / BDW didn't use signed firmware AFAIK
Remove all support for cAVS 1.5 platformsm including Apollo Lake, Sky Lake, Kaby Lake, Broxton and Gemini Lake, they aren't supported any more. Signed-off-by: Guennadi Liakhovetski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One hopefully last request: can you remove the topologies in a separate commit? We're still discussing how topologies will be packaged and released. This should be a very quick change for you: simply move all the changes in tools/
to a separate commit.
@marc-hb why? What difference does it make for this PR? |
Never mind, I forgot other topologies were already removed like this. |
Remove all support for cAVS 1.5 platformsm including Apollo Lake, Sky Lake, Kaby Lake, Broxton and Gemini Lake, they aren't supported any more.