[SKIP CI] .github/zephyr: compare Windows and Linux builds #6950
Conversation
marc-hb
force-pushed
the
compare-win
branch
6 times, most recently
from
a32c62e to
8b74913
Compare
|
Firmware differences between Linux and Windows found in https://github.com/thesofproject/sof/actions/runs/3908863755/jobs/6679699349 should be all fixed by #6920 |
marc-hb
requested review from
dbaluta,
cujomalainey,
lgirdwood and
aborisovich
as code owners
marc-hb
requested review from
paulstelian97,
miRoox,
kv2019i,
aiChaoSONG,
andyross,
dcpleung,
greg-intel,
keqiaozhang and
MaureenHelm
|
|
Windows and Linux have a different zephyr Most likely my fault: commit 68b49c1 |
`git describe` differences happen, especially when trying to optimize cloning and this is for instance what happened in thesofproject#6950 (comment) where zephyr tags were fetched on Linux but not on Windows This also makes plain git version differences more obvious; no need to scroll all the way up and scan the build logs. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
compare-win
branch
2 times, most recently
from
ac6c555 to
acc1433
Compare
Fetching different tags causes `git describe` output to be different. Fixes commit 68b49c1 (".github/zephyr: switch Windows build to west update --narrow") Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
compare-win
branch
5 times, most recently
from
deb3252 to
81c30de
Compare
|
All tests passing now. Binaries generated by Windows and Linux are compared and found identical in https://github.com/thesofproject/sof/actions/runs/3954767889/jobs/6772604198 EDIT: and again in newer https://github.com/thesofproject/sof/actions/runs/3963690378/jobs/6791978755 |
I remember that I did not made |
There was a problem hiding this comment.
Looks great @marc-hb, I'm really glad the output we have on both OSes is the same.
Found a typo, please fix. And some minor things
The End. Signed-off-by: Marc Herbert <[email protected]>
Make CONFIG_BUILD_OUTPUT_STRIPPED mandatory so we can always compare builds. It makes practically zero build space and time difference and has huge reproductibility value, see discussion in zephyrproject-rtos/zephyr#51954 Signed-off-by: Marc Herbert <[email protected]>
`git describe` differences happen, especially when trying to optimize cloning and this is for instance what happened in #6950 (comment) where zephyr tags were fetched on Linux but not on Windows This also makes plain git version differences more obvious; no need to scroll all the way up and scan the build logs. Signed-off-by: Marc Herbert <[email protected]>
The End.
This makes sure Windows builds and Linux builds produce identical binaries.
Signed-off-by: Marc Herbert [email protected]