ipc: add SOF_IPC_PM_CORE_ENABLE message #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #66. |
lgirdwood
requested changes
Jul 9, 2018
src/include/uapi/ipc.h
Outdated
| @@ -101,6 +101,7 @@ | |||
| #define SOF_IPC_PM_CLK_SET SOF_CMD_TYPE(0x004) | |||
| #define SOF_IPC_PM_CLK_GET SOF_CMD_TYPE(0x005) | |||
| #define SOF_IPC_PM_CLK_REQ SOF_CMD_TYPE(0x006) | |||
| #define SOF_IPC_PM_ACTIVE_CORES SOF_CMD_TYPE(0x007) | |||
src/include/uapi/ipc.h
Outdated
| /* enable or disable cores - SOF_IPC_PM_ACTIVE_CORES */ | ||
| struct sof_ipc_pm_active_cores { | ||
| struct sof_ipc_hdr hdr; | ||
| uint32_t cores_mask; |
src/include/uapi/ipc.h
Outdated
| @@ -817,6 +818,12 @@ struct sof_ipc_pm_ctx { | |||
| struct sof_ipc_pm_ctx_elem elems[]; | |||
| }; | |||
|
|
|||
| /* enable or disable cores - SOF_IPC_PM_ACTIVE_CORES */ | |||
| struct sof_ipc_pm_active_cores { | |||
There was a problem hiding this comment.
Best to call this sof_ipc_pm_core_config as we could eventually add other core PM data in here too.
Adds definition and implementation of new IPC message, which allows to enable and disable cores based on passed enable_mask. Signed-off-by: Tomasz Lauda <[email protected]>
tlauda
force-pushed
the
topic/ipc_active_cores
branch
from
45e9344
to
40575d2
Compare
tlauda
changed the title
|
Changed according to review suggestions. |
plbossart
reviewed
Jul 12, 2018
|
Kernel should boot slave cores, when they are needed. Probably just before creating pipeline for specific core. |
|
Probably worthy of more discussions with @lgirdwood @lbetlej and @mmaka1 before merging in -next then? |
|
@mmaka1 is working on some proposal regarding multicore tasking and scheduling, but I think that this change is agnostic. It only exposes interface for enabling cores. How the kernel will use it can be decided later on. |
lgirdwood
approved these changes
Jul 14, 2018
ryans-lee
pushed a commit
to ryans-lee/sof
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Ryan Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds definition and implementation of new IPC
message, which allows to enable and disable cores
based on passed enable_mask.
Signed-off-by: Tomasz Lauda [email protected]