autotools: replace user variables with automake variables #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janusz Jankowski <[email protected]>
lgirdwood
approved these changes
Jul 9, 2018
|
This change will cause compile issue for each platform. |
ryans-lee
pushed a commit
to ryans-lee/sof
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Ryan Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our autotools configs shouldn't use user variables such as CFLAGS and LDFLAGS, so I moved their contents to AM_CFLAGS and AM_LDFLAGS and updated all affected makefiles.
Also I had to add AM_CCASFLAGS which is used for .S files, previously CFLAGS were added while compiling these files what can be misleading and we may want to not have the same CFLAGS for c and .S sources. So now we have to set AM_CFLAGS for c files and AM_CCASFLAGS for as files.
AM_CCASFLAGS are intially set to the same value as AM_CFLAGS for backward compatibility, but it would be good to check if we really need all these flags for our .S files.
Order of the flags passed to tools changed, because AM/target flags are added before user CFLAGS but binaries look to be the same, checked with:
Signed-off-by: Janusz Jankowski [email protected]