Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc4: add mixing-based processing in channel selector #6383

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

tlissows
Copy link
Contributor

@tlissows tlissows commented Oct 7, 2022

Add mixing-based processing in channel selector to implement capabilities resulting from IPC4 configuration.

Signed-off-by: Tomasz Lissowski [email protected]

src/audio/selector/selector.c Outdated Show resolved Hide resolved
src/audio/selector/selector.c Outdated Show resolved Hide resolved
src/audio/selector/selector_generic.c Show resolved Hide resolved
src/audio/selector/selector_generic.c Show resolved Hide resolved
@aiChaoSONG aiChaoSONG requested a review from RanderWang October 11, 2022 06:19
@tlissows tlissows requested review from lyakh and RanderWang October 11, 2022 15:43
Copy link
Collaborator

@RanderWang RanderWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@tlissows tlissows requested a review from singalsu October 13, 2022 08:21
@wszypelt
Copy link

SOFCI TEST

@miRoox
Copy link

miRoox commented Oct 14, 2022

SOFCI TEST

src/include/sof/audio/selector.h Outdated Show resolved Hide resolved
src/include/sof/audio/selector.h Show resolved Hide resolved
Add mixing-based processing in channel selector to implement
capabilities resulting from IPC4 configuration. Enable flexible
channels count (from 1 to 8) independently for input and output.

Signed-off-by: Tomasz Lissowski <[email protected]>
@tlissows tlissows requested a review from mmaka1 October 14, 2022 13:36
@kv2019i
Copy link
Collaborator

kv2019i commented Oct 17, 2022

@mmaka1 Good to go?

@kv2019i
Copy link
Collaborator

kv2019i commented Oct 18, 2022

Known fail in IPC4 test set, proceeding with merge.

@kv2019i kv2019i merged commit 8c60a56 into thesofproject:main Oct 18, 2022
@tlissows tlissows deleted the sof-selector_ipc4 branch October 18, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants