host: unify component for all DMA types #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DW-DMA should ignore copy call if flags include DMA_COPY_PRELOAD. Signed-off-by: Tomasz Lauda <[email protected]>
Unifies host_copy implementation for all types of DMA. Signed-off-by: Tomasz Lauda <[email protected]>
Ignores request for HDA-DMA configuration if the channel is in active state. Signed-off-by: Tomasz Lauda <[email protected]>
Checks if dma_sg_elem_array buffer is allocated before performing cache writeback or invalidation. Signed-off-by: Tomasz Lauda <[email protected]>
Changes host_buffer component ops to be a subtype of component set_attribute ops. This change allows to unify host implementation across different types of DMA. Signed-off-by: Tomasz Lauda <[email protected]>
Signed-off-by: Tomasz Lauda <[email protected]>
Removes period_bytes field from host_data struct. This field is only used in host_params, so we don't need it globally. Signed-off-by: Tomasz Lauda <[email protected]>
Adds support for one shot copy to DW-DMA. One shot means that transfer isn't circular, so every copy is basically just restart of DMA engine. Signed-off-by: Tomasz Lauda <[email protected]>
dbaluta
reviewed
Jun 13, 2019
| struct hc_buf host; | ||
| #if !CONFIG_DMA_GW | ||
| struct hc_buf local; |
There was a problem hiding this comment.
Here we still branch on CONFIG_DMA_GW. Is this as intended? Because the PR description says we no longer need to branch on this config option.
There was a problem hiding this comment.
@tlauda I now see the last patch where the config is removed. So, it looks good to me.
lgirdwood
approved these changes
Jun 13, 2019
jajanusz
reviewed
Jun 13, 2019
src/audio/host.c
Outdated
|
|
||
| if (local_elem->src == hd->source->current_end) { | ||
| /* end of element, so use next */ | ||
| source_elem = next_buffer(hd->source); | ||
| hd->source->current_end = source_elem->src + source_elem->size; |
There was a problem hiding this comment.
Codecheck complains that source_elem can be null here.
jajanusz
reviewed
Jun 13, 2019
src/audio/host.c
Outdated
|
|
||
| if (local_elem->dest == hd->sink->current_end) { | ||
| /* end of element, so use next */ | ||
| sink_elem = next_buffer(hd->sink); | ||
| hd->sink->current_end = sink_elem->dest + sink_elem->size; |
There was a problem hiding this comment.
Codecheck complains that sink_elem can be null here.
|
@tlauda We should be careful to run all regression test we have! Other than that, excellent work! |
dbaluta
approved these changes
Jun 14, 2019
|
@tlauda ping, UT and CodeCheck didn't pass |
Unifies host component for all DMA types. We don't need to branch on CONFIG_DMA_GW anymore. Signed-off-by: Tomasz Lauda <[email protected]>
tlauda
force-pushed
the
topic/host-refactor2
branch
from
30ab3f7
to
2825d47
Compare
|
@mengdonglin @keqiaozhang It's been over a week. Can I assume that it's not breaking legacy platforms? |
|
@tlauda I have a feeling there has been some national holidays for @mengdonglin and @keqiaozhang last week but some folks seem back today. |
|
I have done sanity test for this PR on apl and byt platform. env Test result
|
|
@Jiangxinx To sum up, do we have any regression or not? |
|
Sorry to this mission: This pr have not another regression issues |
This was referenced Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies host component for all DMA types.
We don't need to branch on CONFIG_DMA_GW anymore.
Closes #1052.
Signed-off-by: Tomasz Lauda [email protected]