Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume: Fix channels number validate for volume_ctrl_get_cmd(..) #119

Conversation

kakulesza
Copy link
Collaborator

Signed-off-by: Kamil Kulesza [email protected]

@kakulesza kakulesza requested a review from lgirdwood July 17, 2018 13:18
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add a comment that this is the mirror of #91 for the get case.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain changes in commit mesage.

volume_ctrl_get_cmd should accept 8 channels. This is the mirror of pull request thesofproject#91 (commit ff2e969).

Signed-off-by: Kamil Kulesza <[email protected]>
@kakulesza kakulesza force-pushed the fix-volume-get-cmd-channels-validate branch from c2ae610 to 0802c72 Compare July 18, 2018 09:34
@tlauda
Copy link
Contributor

tlauda commented Jul 24, 2018

The same change has been already merged #126.

@tlauda tlauda closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants