-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hdadma : DMA flow unification #114
Conversation
Prepared for hda stream_tag, same for host/dai and dw-dma/hda-dma. Signed-off-by: Marcin Maka <[email protected]>
Signed-off-by: Marcin Maka <[email protected]>
Signed-off-by: Marcin Maka <[email protected]>
This commit enable hda-dma in FW, also improve sending callback function by checking write pointer position in buffer.
Signed-off-by: Adam Wladzinski <[email protected]>
Signed-off-by: Adam Wladzinski <[email protected]>
Signed-off-by: Adam Wladzinski <[email protected]>
Signed-off-by: Adam Wladzinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I've only done a partial review since I can see some of the patches are needing to be squashed. Can you also add commit messages (why and how changes are being made) and do the PR against the next branch (sinec master is stabilising).
src/drivers/hda-dma.c
Outdated
{ | ||
struct dai *dai = (struct dai *)data; | ||
struct dma_pdata *p = dma_get_drvdata(dma); | ||
int32_t gval; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation looks wrong.
src/drivers/hda-dma.c
Outdated
*/ | ||
*/ | ||
|
||
uint32_t dgbwp = host_dma_reg_read(dma, channel, DGBWP); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All variable declerations should be at the top.
oh, and please also delete the merge commit. thanks. |
Kind reminder that we try to use the Linux style, and I get tons of issues reported by checkpatch.pl.
|
@plbossart I think you have to escape '#' char cos you are referencing a lot of random pull requestes |
@mUfoq i fixed the comments, please fix your code... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too big a commit. you should spit them for easy review, e.g. 1st: add dma_sg_alloc/free; 2nd: replace existed list with array. and you may need specify why you are doing this change.
CI observed building failure. Failed Platform: baytrail apollolake cannonlake configure: error: in `/build/sof/src': |
@jiawang6 this PR will be is on a version of master that does not have configure.ac fix. It will be rebased soon and will be getting merged into -next (after squash/rebase). |
It is a bit big package, but after consulting our DL Marcin, we decided that only in this way we will not crash CI.