Skip to content

Commit

Permalink
src/arch/xtensa: normalize two odd files from CRLF to LF
Browse files Browse the repository at this point in the history
These two generated files are the only ones stored with CRLF in git end
of lines for no reason. Probably because they were generated on Windows,
then copied to Linux before being checked into git. If they had been
added to git running on Windows then the default `autocrlf=true` would
have likely converted them to LF.

These CRLF EOLs have caused a `git hash-object` mismatch before as seen
in #5917). Now that Windows is compiling SOF, #5920 must be
reverted (see previous commit) and they are causing mismatches again.

While this normalization unfortunately causes some large git noise, that
noise can be easily filtered out with [ git ] diff -b or -w or
--ignore-space-at-eol. Github and many others also have similar
filtering options. Temporarily converting them locally with `unix2dos`
or any editor is another option.

As they are generated, comparisons should most often be performed from
the source(s) they come from anyway.

Signed-off-by: Marc Herbert <[email protected]>
  • Loading branch information
marc-hb committed Jan 11, 2023
1 parent 73909b4 commit f2de92a
Show file tree
Hide file tree
Showing 2 changed files with 2,292 additions and 2,292 deletions.
Loading

0 comments on commit f2de92a

Please sign in to comment.