Skip to content

Commit

Permalink
platform: remove support for Broadwell and Haswell
Browse files Browse the repository at this point in the history
Remove all support for Broadwell and Haswell platforms, they
aren't supported any more.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
  • Loading branch information
lyakh authored and lgirdwood committed Feb 16, 2023
1 parent 70f9faf commit d806350
Show file tree
Hide file tree
Showing 59 changed files with 13 additions and 6,735 deletions.
2 changes: 0 additions & 2 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ src/audio/codec_adapter/* @cujomalainey @abonislawski @dbaluta
src/audio/google/* @thesofproject/google

# platforms
src/platform/haswell/* @randerwang
src/platform/suecreek/* @lyakh
src/arch/xtensa/debug/gdb/* @abonislawski
src/platform/imx8/** @dbaluta
Expand All @@ -50,7 +49,6 @@ src/platform/mt8195/** @yaochunhung @kuanhsuncheng
# drivers
src/drivers/intel/dmic.c @singalsu
src/drivers/intel/cavs/sue-iomux.c @lyakh
src/drivers/intel/haswell/* @randerwang
src/drivers/imx/** @dbaluta
src/drivers/dw/* @lyakh
src/drivers/amd/* @bhiregoudar @sunilkumardommati
Expand Down
5 changes: 2 additions & 3 deletions scripts/docker_build/sof_builder/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ RUN cd "$HOME" && \
git clone $CLONE_DEFAULTS --branch sof-gcc10x $CT_NG_REPO && \
cd crosstool-ng && \
./bootstrap && ./configure --prefix=`pwd` && make && make install && \
for arch in hsw apl cnl imx imx8m imx8ulp rn rmb mt8186 mt8195; do \
for arch in apl cnl imx imx8m imx8ulp rn rmb mt8186 mt8195; do \
echo "$arch: ct-ng build start..." && \
cp config-${arch}-gcc10.2-gdb9 .config && \
# replace the build dist to save space
Expand All @@ -99,7 +99,6 @@ RUN cd "$HOME" && \
done && \
echo "Stage2: xtensa-overlay, crosstool-ng are done!"

ENV PATH="/home/sof/work/xtensa-hsw-elf/bin:${PATH}"
ENV PATH="/home/sof/work/xtensa-apl-elf/bin:${PATH}"
ENV PATH="/home/sof/work/xtensa-cnl-elf/bin:${PATH}"
ENV PATH="/home/sof/work/xtensa-rn-elf/bin:${PATH}"
Expand All @@ -114,7 +113,7 @@ ARG NEWLIB_REPO=https://github.com/jcmvbkbc/newlib-xtensa.git
RUN cd "$HOME" && \
git clone $CLONE_DEFAULTS --branch xtensa $NEWLIB_REPO && \
cd newlib-xtensa && \
for arch in hsw apl cnl imx imx8m imx8ulp rn rmb mt8186 mt8195; do \
for arch in apl cnl imx imx8m imx8ulp rn rmb mt8186 mt8195; do \
./configure --target=xtensa-${arch}-elf \
--prefix=/home/sof/work/xtensa-root && \
make && make install && \
Expand Down
19 changes: 1 addition & 18 deletions scripts/qemu-check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Copyright(c) 2018 Intel Corporation. All rights reserved.
set -e

SUPPORTED_PLATFORMS=(bdw hsw apl icl skl kbl cnl imx8 imx8x imx8m)
SUPPORTED_PLATFORMS=(apl icl skl kbl cnl imx8 imx8x imx8m)

SOF_DIR=$(cd "$(dirname "$0")" && cd .. && pwd)

Expand Down Expand Up @@ -81,23 +81,6 @@ do

has_rom=false
case "$platform" in
bdw)
READY_IPC="00 3c 01 80"
OUTBOX_OFFSET="9e000"
SHM_IPC_REG=qemu-bridge-shim-io
SHM_MBOX=qemu-bridge-dram-mem
;;
hsw)
# This READY_IPC value comes from:
# shim_write(SHIM_IPCD, outbox | SHIM_IPCD_BUSY);
# outbox=MAILBOX_HOST_OFFSET >> 3;
# MAILBOX_HOST_OFFSET>>3 = 0xFC00
# IPC_DIPCIDR_BUSY = BIT(31)
READY_IPC="00 fc 00 80"
OUTBOX_OFFSET="7e000"
SHM_IPC_REG=qemu-bridge-shim-io
SHM_MBOX=qemu-bridge-dram-mem # some DMA traces visible here
;;
apl)
# This READY_IPC value comes from:
# ipc_write(IPC_DIPCIDR, IPC_DIPCIDR_BUSY | header);
Expand Down
14 changes: 1 addition & 13 deletions scripts/xtensa-build-all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ SUPPORTED_PLATFORMS+=( mt8188 )
# Not actually "supported" in the main branch anymore (go to stable-v2.3
# instead) but kept here for historical reasons and experimentation
# convenience.
SUPPORTED_PLATFORMS+=( hsw bdw apl skl kbl cnl sue icl jsl )
SUPPORTED_PLATFORMS+=( apl skl kbl cnl sue icl jsl )

BUILD_ROM=no
BUILD_DEBUG=no
Expand Down Expand Up @@ -204,18 +204,6 @@ do
PLATFORM_PRIVATE_KEY=''

case $platform in
bdw)
PLATFORM="broadwell"
XTENSA_CORE="LX4_langwell_audio_17_8"
HOST="xtensa-hsw-elf"
XTENSA_TOOLS_VERSION="RG-2017.8-linux"
;;
hsw)
PLATFORM="haswell"
XTENSA_CORE="LX4_langwell_audio_17_8"
HOST="xtensa-hsw-elf"
XTENSA_TOOLS_VERSION="RG-2017.8-linux"
;;
apl)
PLATFORM="apollolake"
XTENSA_CORE="X4H3I16w2D48w3a_2017_8"
Expand Down
8 changes: 2 additions & 6 deletions src/arch/xtensa/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@

# platform-specific values

if(CONFIG_HASWELL)
set(platform_folder haswell)
elseif(CONFIG_BROADWELL)
set(platform_folder haswell)
elseif(CONFIG_APOLLOLAKE)
if(CONFIG_APOLLOLAKE)
set(platform_folder apollolake)
elseif(CONFIG_CANNONLAKE)
set(platform_folder cannonlake)
Expand Down Expand Up @@ -545,7 +541,7 @@ add_custom_target(
# Keep lists below in sync with rimage/config/*.toml

# .ri not signed: nothing variable in it to erase.
set(UNSIGNED_RI hsw bdw sue)
set(UNSIGNED_RI sue)
# NXP
list(APPEND UNSIGNED_RI imx8 imx8x imx8m imx8ulp)
# AMD
Expand Down
6 changes: 0 additions & 6 deletions src/arch/xtensa/configs/broadwell_defconfig

This file was deleted.

5 changes: 0 additions & 5 deletions src/arch/xtensa/configs/haswell_defconfig

This file was deleted.

30 changes: 0 additions & 30 deletions src/drivers/dw/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -477,34 +477,6 @@ static int dw_dma_status(struct dma_chan_data *channel,
return 0;
}

/* mask address for dma to identify memory space.
* It is requested by HSW, BDW. For other
* platforms, the mask is zero.
*/
static void dw_dma_mask_address(struct dma_sg_elem *sg_elem,
struct dw_lli *lli_desc, uint32_t direction)
{
lli_desc->sar = sg_elem->src;
lli_desc->dar = sg_elem->dest;

switch (direction) {
case DMA_DIR_LMEM_TO_HMEM:
case DMA_DIR_MEM_TO_DEV:
lli_desc->sar |= PLATFORM_DW_DMA_HOST_MASK;
break;
case DMA_DIR_HMEM_TO_LMEM:
case DMA_DIR_DEV_TO_MEM:
lli_desc->dar |= PLATFORM_DW_DMA_HOST_MASK;
break;
case DMA_DIR_MEM_TO_MEM:
lli_desc->sar |= PLATFORM_DW_DMA_HOST_MASK;
lli_desc->dar |= PLATFORM_DW_DMA_HOST_MASK;
break;
default:
break;
}
}

/* set the DMA channel configuration, source/target address, buffer sizes */
static int dw_dma_set_config(struct dma_chan_data *channel,
struct dma_sg_config *config)
Expand Down Expand Up @@ -737,8 +709,6 @@ static int dw_dma_set_config(struct dma_chan_data *channel,
goto out;
}

dw_dma_mask_address(sg_elem, lli_desc, config->direction);

if (sg_elem->size > DW_CTLH_BLOCK_TS_MASK) {
tr_err(&dwdma_tr, "dw_dma_set_config(): dma %d channel %d block size too big %d",
channel->dma->plat_data.id,
Expand Down
4 changes: 1 addition & 3 deletions src/drivers/intel/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause

if(CONFIG_HASWELL OR CONFIG_BROADWELL)
add_subdirectory(haswell)
elseif(CONFIG_CAVS)
if(CONFIG_CAVS)
add_subdirectory(cavs)
endif()

Expand Down
8 changes: 0 additions & 8 deletions src/drivers/intel/haswell/CMakeLists.txt

This file was deleted.

104 changes: 0 additions & 104 deletions src/drivers/intel/haswell/interrupt.c

This file was deleted.

Loading

0 comments on commit d806350

Please sign in to comment.