sof_remove.sh: Remove all ALSA modules #812
Conversation
|
https://sof-ci.01.org/softestpr/PR812/build931/devicetest failed with |
Ping @ujfalusi ? Is this still something you'd like? |
ujfalusi
force-pushed
the
pr/kmod_remove_all_sound_01
branch
from
f15061b
to
6f7ba72
Compare
|
Changes since v1:
If we still see failure then we might want to drop this as we can not list all modules we might encounter... |
|
https://sof-ci.01.org/softestpr/PR812/build959/devicetest/ is all green now.
In that case can you please isolate all these into a new section with some "ALSA modules" title + this comment? |
It is passing now in CI so we are covering nicely the common modules, but if you have some new device spanning out new module then it will stop working as we are aiming to take down the whole audio subsystem now. |
|
Is there a new device checklist? We'd have to add an entry to this file to prevent failure if the new device brings a unique module with it? Or am I not understanding? |
There was a problem hiding this comment.
Is there a new device checklist? We'd have to add an entry to this file to prevent failure if the new device brings a unique module with it? Or am I not understanding?
Yes I think we just grow this list as needed. For me what's missing now is a very brief summary of this discussion in the code itself.
|
SOFCI TEST |
|
Unlikely conflict with unrelated 2ff9c0b, can you please rebase? Also, please summarize the discussion above in the code. |
|
@ujfalusi can you please:
|
Remove the remaining ALSA modules to have completely fresh start when inserting the modules. This way we can also test module parameters for the core. Signed-off-by: Peter Ujfalusi <[email protected]>
|
Changes since v2:
|
ujfalusi
force-pushed
the
pr/kmod_remove_all_sound_01
branch
from
6f7ba72
to
32603a8
Compare
There was a problem hiding this comment.
LGTM but someone familiar with modules must approve. @plbossart , @bardliao maybe?
The LNL overruns in https://sof-ci.01.org/softestpr/PR812/build656/devicetest/index.html are interesting but unrelated. Everything else is either green or not available.
EDIT: overruns filed in new https://github.com/thesofproject/linux/issues/ 5109
Remove the remaining ALSA modules to have completely fresh start when
inserting the modules.
This way we can also test module parameters for the core.
Signed-off-by: Peter Ujfalusi [email protected]