Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sof-kernel-log-check: ignore an ime error for CML and ICL #398

Merged
merged 1 commit into from
Oct 15, 2020
Merged

sof-kernel-log-check: ignore an ime error for CML and ICL #398

merged 1 commit into from
Oct 15, 2020

Conversation

aiChaoSONG
Copy link

@aiChaoSONG aiChaoSONG commented Sep 23, 2020 •
edited
Loading

Commit f764b59 ignore an ime error, and the similiar
ime error is observed again, but with a different PCI ID,
we need to ignore both.

Check daily report #473 / #457 suspend-resume test case for the error.

@aiChaoSONG aiChaoSONG requested a review from a team as a code owner September 23, 2020 03:01
marc-hb
marc-hb previously requested changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@marc-hb marc-hb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how a kernel version can changed PCI IDs, can you explain?

This makes line 21 redundant, need to merge the two.

While doing this please address comments in the previous review (mainly use a platform dependent case)

@marc-hb marc-hb self-requested a review September 23, 2020 03:12
@marc-hb marc-hb dismissed their stale review September 23, 2020 03:13

missed the difference

xiulipan
xiulipan previously requested changes Sep 23, 2020
View reviewed changes
tools/sof-kernel-log-check.sh Outdated
# https://github.com/thesofproject/sof-test/issues/389
ignore_str="$ignore_str"'|mei_me 0000:00:16\.4: hw_reset failed ret = -62'
ignore_str="$ignore_str"'|mei_me 0000:00:16\..: hw_reset failed ret = -62'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it is better to ignore the exact pci id here and match it with a pattern?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a . here is good enough.

@aiChaoSONG
Copy link
Author

@marc-hb My bad, it is actually the same sof-dev kernel, but with different FW (stable 1.6 vs master). Check the daily report 457/473, the IDs are different, but the error message are the same:

  • [ 6733.766202] mei_me 0000:00:16.0: hw_reset failed ret = -62
  • [ 6965.377054] mei_me 0000:00:16.4: hw_reset failed ret = -62

@aiChaoSONG aiChaoSONG changed the title sof-kernel-log-check: ignore an ime error for CML and ICL [not merge]sof-kernel-log-check: ignore an ime error for CML and ICL Sep 23, 2020
@aiChaoSONG
Copy link
Author

@xiulipan @marc-hb Let's first address why the IDs are different, any idea?

@aiChaoSONG aiChaoSONG force-pushed the ignore_mei branch 2 times, most recently from 8e7de6e to 441d739 Compare September 23, 2020 03:44
@aiChaoSONG aiChaoSONG changed the title [not merge]sof-kernel-log-check: ignore an ime error for CML and ICL sof-kernel-log-check: ignore an ime error for CML and ICL Sep 23, 2020
marc-hb
marc-hb previously approved these changes Sep 23, 2020
View reviewed changes
@xiulipan
Copy link
Contributor

@aiChaoSONG The id is mapped to real hardware. The PCI bus is 0000:00:16 and the following number is the sub-bus. If the hardware is connected to different slot, the id may also change. So I think we may also need to confirm the mei_me is always on 0000:00:16

Please rebase and merge this PR

@aiChaoSONG
Copy link
Author

@xiulipan OK, I will check the log on every platform to see if the ME module got the same ID.

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 24, 2020

@xiulipan OK, I will check the log on every platform to see if the ME module got the same ID.

We can add this now if it solves a current problem and easily change it to a wildcard later if needed.

@xiulipan
Copy link
Contributor

We can add this now if it solves a current problem and easily change it to a wildcard later if needed.

@marc-hb Agreed. @aiChaoSONG Please rebase and merge this PR

@xiulipan xiulipan self-requested a review September 24, 2020 06:14
marc-hb
marc-hb requested changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you dropped the removal of the duplicate on line 25.

sof-kernel-log-check: ignore an ime error for CML and ICL
7fdc1b4 
Commit f764b59 ignore an ime error, and the similiar
ime error is observed again, but with a different PCI ID,
we need to ignore both.

And also make the ignorance platform specific.

Signed-off-by: Amery Song <[email protected]>
@aiChaoSONG aiChaoSONG dismissed xiulipan’s stale review October 15, 2020 01:46

requested changes are done

@aiChaoSONG aiChaoSONG merged commit 78cb66d into thesofproject:master Oct 15, 2020
@marc-hb marc-hb added the area:non-audio Failure False positives: failing when we don't want to label Oct 15, 2021
@aiChaoSONG aiChaoSONG deleted the ignore_mei branch October 24, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-hb marc-hb marc-hb approved these changes

@xiulipan xiulipan Awaiting requested review from xiulipan

Assignees
No one assigned
Labels
area:non-audio Failure False positives: failing when we don't want to
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aiChaoSONG @xiulipan @marc-hb