Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmod: Add modules useful for imx platforms #1236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kmod: Add modules useful for imx platforms #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/kmod/sof_insert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,11 @@ insert_module snd_soc_es8316
insert_module snd_soc_es8326

insert_module snd_soc_wm8960
insert_module snd_soc_simple_card

# core SOF driver
insert_module snd_sof
insert_module snd_sof_utils
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be at least a separate commit. Maybe even a separate PR if there's any debate about snd_soc_simple_card?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless simple_card depends on utils ? @AnneOnciulescu pls confirm.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message says "Also, snd_sof_utils was missing from sof_insert.sh." which is a pretty clear sign this is a separate bug fix.


# insert top-level ACPI/PCI SOF drivers. They will register SOF components and
# load machine drivers as needed. Do not insert any other sort of audio module,
Expand Down
1 change: 1 addition & 0 deletions tools/kmod/sof_remove.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ remove_module snd_hda_codec_realtek
remove_module snd_hda_codec_generic

remove_module snd_soc_wm8960
remove_module snd_soc_simple_card

#-------------------------------------------
# Remaining core SOF parts
Expand Down
Loading