Remove unnecessary clone() functions in hull
#1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Klim Tsoutsman <[email protected]>
tsoutsman
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Thank you!
Either between when that code was written and now the compiler gained the ability to reason about return statements in loop bodies, or I underestimated the compiler when writing the code. Judging by the last clearly unnecessary clone, it was probably the latter.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Commands can take ownership of `previous_output` as they then overwrite it anyway. * The final command can take ownership of all streams. --------- Co-authored-by: Poxxy <[email protected]> Co-authored-by: Klim Tsoutsman <[email protected]> ffb5e8b
github-actions bot
pushed a commit
to tsoutsman/Theseus
that referenced
this pull request
Jan 6, 2024
…1089) * Commands can take ownership of `previous_output` as they then overwrite it anyway. * The final command can take ownership of all streams. --------- Co-authored-by: Poxxy <[email protected]> Co-authored-by: Klim Tsoutsman <[email protected]> ffb5e8b
github-actions bot
pushed a commit
to sunshine-lcc/Theseus
that referenced
this pull request
Feb 7, 2024
…1089) * Commands can take ownership of `previous_output` as they then overwrite it anyway. * The final command can take ownership of all streams. --------- Co-authored-by: Poxxy <[email protected]> Co-authored-by: Klim Tsoutsman <[email protected]> ffb5e8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
TODOspecifically pointing out some unneededclone()functions being used which this PR addresses. A total of 5 clones can be removed safely.