Merge pull request #292 from astares/290-Do-not-use-notNil---use-isNo…

…tNil-instead Do not use notNil - use isNotNil instead
theseion · Jan 27, 2024 · cfde462 · cfde462
2 parents d276a70 + ffd30c0
commit cfde462
Show file tree

Hide file tree

Showing 16 changed files with 17 additions and 17 deletions.
diff --git a/...LBlockClosureSerializationTest.class/instance/testBlockClosureChangeDifferentBytecodes.st b/...LBlockClosureSerializationTest.class/instance/testBlockClosureChangeDifferentBytecodes.st
@@ -12,7 +12,7 @@ testBlockClosureChangeDifferentBytecodes
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self assert: aClosure isClean.
-	self assert: aClosure notNil.
+	self assert: aClosure isNotNil.
 
 	self serialize: aClosure.
 	self classFactory

diff --git a/...age/FLBlockClosureSerializationTest.class/instance/testBlockClosureChangeSameBytecodes.st b/...age/FLBlockClosureSerializationTest.class/instance/testBlockClosureChangeSameBytecodes.st
@@ -12,7 +12,7 @@ testBlockClosureChangeSameBytecodes
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self assert: aClosure isClean.
-	self assert: aClosure outerContext notNil.
+	self assert: aClosure outerContext isNotNil.
 
 	self serialize: aClosure.
 	self classFactory

diff --git a/...e-Tests.package/FLBlockClosureSerializationTest.class/instance/testBlockClosureRemoved.st b/...e-Tests.package/FLBlockClosureSerializationTest.class/instance/testBlockClosureRemoved.st
@@ -12,7 +12,7 @@ testBlockClosureRemoved
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self assert: aClosure isClean.
-	self assert: aClosure outerContext notNil.
+	self assert: aClosure outerContext isNotNil.
 
 	self serialize: aClosure.
 	aClass removeSelectorSilently: #methodWithClosure.

diff --git a/...package/FLBlockClosureSerializationTest.class/instance/testBlockClosureRemovedNonClean.st b/...package/FLBlockClosureSerializationTest.class/instance/testBlockClosureRemovedNonClean.st
@@ -9,7 +9,7 @@ testBlockClosureRemovedNonClean
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self deny: aClosure isClean.
-	self assert: aClosure outerContext notNil.
+	self assert: aClosure outerContext isNotNil.
 
 	self serialize: aClosure.
 	aClass removeSelectorSilently: #methodWithClosure.

diff --git a/...tory/Fuel-Core-Tests.package/FLCompiledMethodSerializationTest.class/instance/testDoIt.st b/...tory/Fuel-Core-Tests.package/FLCompiledMethodSerializationTest.class/instance/testDoIt.st
@@ -14,7 +14,7 @@ testDoIt
 	self deny: materialized isInstalled.
 	self assert: materialized isDoIt.
 	"we serialized the source, trailer is cleared"
-	self assert: materialized sourceCode notNil.
+	self assert: materialized sourceCode isNotNil.
 	self deny: materialized hasSourcePointer.
 
 	self assert: (materialized isEqualRegardlessTrailerTo: theCompiledMethod)
diff --git a/...e-Tests.package/FLCompiledMethodSerializationTest.class/instance/testInstalledModified.st b/...e-Tests.package/FLCompiledMethodSerializationTest.class/instance/testInstalledModified.st
@@ -23,4 +23,4 @@ testInstalledModified
 	self deny: materialized isInstalled.
 	self deny: materialized isDoIt.
 	"we serialized the source"
-	self assert: materialized sourceCode notNil.
+	self assert: materialized sourceCode isNotNil.
diff --git a/...l-Core-Tests.package/FLCompiledMethodSerializationTest.class/instance/testNotInstalled.st b/...l-Core-Tests.package/FLCompiledMethodSerializationTest.class/instance/testNotInstalled.st
@@ -13,7 +13,7 @@ testNotInstalled
 	self deny: materialized isInstalled.
 	self deny: materialized isDoIt.
 	"we serialized the source, trailer is empty"
-	self assert: materialized sourceCode notNil.
+	self assert: materialized sourceCode isNotNil.
 	self deny: materialized hasSourcePointer.
 
 	self assert: (materialized isEqualRegardlessTrailerTo: theCompiledMethod)
diff --git a/...lBlockClosureSerializationTest.class/instance/testBlockClosureChangeDifferentBytecodes.st b/...lBlockClosureSerializationTest.class/instance/testBlockClosureChangeDifferentBytecodes.st
@@ -12,7 +12,7 @@ testBlockClosureChangeDifferentBytecodes
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self assert: aClosure isClean.
-	self assert: aClosure outerContext notNil.
+	self assert: aClosure outerContext isNotNil.
 
 	self serializer fullySerializeMethod: aClosure compiledBlock method.
 	self serialize: aClosure.

diff --git a/...osureSerializationTest.class/instance/testBlockClosureChangeDifferentBytecodesNonClean.st b/...osureSerializationTest.class/instance/testBlockClosureChangeDifferentBytecodesNonClean.st
@@ -9,7 +9,7 @@ testBlockClosureChangeDifferentBytecodesNonClean
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self deny: aClosure isClean.
-	self assert: aClosure outerContext notNil.
+	self assert: aClosure outerContext isNotNil.
 
 	self serializer fullySerializeMethod: aClosure compiledBlock method.
 	self serialize: aClosure.

diff --git a/...sts.package/FLFullBlockClosureSerializationTest.class/instance/testBlockClosureRemoved.st b/...sts.package/FLFullBlockClosureSerializationTest.class/instance/testBlockClosureRemoved.st
@@ -12,7 +12,7 @@ testBlockClosureRemoved
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self assert: aClosure isClean.
-	self assert: aClosure outerContext notNil.
+	self assert: aClosure outerContext isNotNil.
 
 	self serializer fullySerializeMethod: aClosure compiledBlock method.
 	self serialize: aClosure.

diff --git a/...age/FLFullBlockClosureSerializationTest.class/instance/testBlockClosureRemovedNonClean.st b/...age/FLFullBlockClosureSerializationTest.class/instance/testBlockClosureRemovedNonClean.st
@@ -9,7 +9,7 @@ testBlockClosureRemovedNonClean
 		in: aClass.
 	aClosure := aClass new perform: #methodWithClosure.
 	self deny: aClosure isClean.
-	self assert: aClosure outerContext notNil.
+	self assert: aClosure outerContext isNotNil.
 
 	self serializer fullySerializeMethod: aClosure compiledBlock method.
 	self serialize: aClosure.

diff --git a/...tory/Fuel-Core-Tests.package/FLLimitingSerializationTest.class/instance/testDepthLimit.st b/...tory/Fuel-Core-Tests.package/FLLimitingSerializationTest.class/instance/testDepthLimit.st
@@ -17,9 +17,9 @@ testDepthLimit
 		serialize.
 
 	materialized := self materialized.
-	self assert: materialized left notNil.
+	self assert: materialized left isNotNil.
 	self assert: materialized right equals: 1.
-	self assert: materialized left left notNil.
+	self assert: materialized left left isNotNil.
 	self assert: materialized left right equals: 2.
 	self assert: materialized left left left isNil.
 	self assert: materialized left left right isNil
diff --git a/...Tests.package/FLLimitingSerializationTest.class/instance/testEnableObjectsLimitWarning.st b/...Tests.package/FLLimitingSerializationTest.class/instance/testEnableObjectsLimitWarning.st
@@ -23,7 +23,7 @@ testEnableObjectsLimitWarning
 		do: [ :ex | ex resume ].
 
 	materialized := self materialized.
-	self assert: materialized left notNil.
+	self assert: materialized left isNotNil.
 	self assert: materialized right equals: 1.
 	self assert: materialized left left isNil.
 	self assert: materialized left right isNil
diff --git a/...ory/Fuel-Core-Tests.package/FLLimitingSerializationTest.class/instance/testObjectLimit.st b/...ory/Fuel-Core-Tests.package/FLLimitingSerializationTest.class/instance/testObjectLimit.st
@@ -17,7 +17,7 @@ testObjectLimit
 		serialize.
 
 	materialized := self materialized.
-	self assert: materialized left notNil.
+	self assert: materialized left isNotNil.
 	self assert: materialized right equals: 1.
 	self assert: materialized left left isNil.
 	self assert: materialized left right equals: 2
diff --git a/repository/Fuel-Core.package/FLDepthLimitingAnalysis.class/instance/mapAndTrace..st b/repository/Fuel-Core.package/FLDepthLimitingAnalysis.class/instance/mapAndTrace..st
@@ -4,7 +4,7 @@ mapAndTrace: anObject
 		ifTrue: [ depth := depth + 1 ].
 	previousStackSize := objectStack size.
 
-	(anObject notNil and: [
+	(anObject isNotNil and: [
 		depth  > depthLimit])
 			ifTrue: [
 				firstMapper

diff --git a/repository/Fuel-Core.package/FLDepthLimitingAnalysis.class/properties.json b/repository/Fuel-Core.package/FLDepthLimitingAnalysis.class/properties.json
@@ -1,5 +1,5 @@
 {
-	"commentStamp" : "MaxLeske 6/21/2021 12:59",
+	"commentStamp" : "",
 	"super" : "FLAnalysis",
 	"category" : "Fuel-Core-Base",
 	"classinstvars" : [ ],